Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#283 - Resize span #3678

Merged
merged 3 commits into from
Jan 4, 2023
Merged

#283 - Resize span #3678

merged 3 commits into from
Jan 4, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Jan 3, 2023 •
edited
Loading

What's in the PR

  • Add resizing functionality in brat editor
  • Add undo functionality for resizing actions
  • Fix drag not ending when mouse is released outside event control scope

How to test manually

  • When hovering with the mouse over an annotation bubble in the brat editor, orange handles appear on the left and right side. If the bubble is split, they will appear on the first/last bubble respectively - try grabbing them with the mouse and dragging them to change the annotation size

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#283 - Resize span
befe83d 
- Add resizing functionality in brat editor
- Add undo functionality for resizing actions
@reckart reckart added this to the 27.0 milestone Jan 3, 2023
@reckart reckart self-assigned this Jan 3, 2023
reckart added 2 commits January 4, 2023 10:46
@reckart
#283 - Resize span
a1b366d 
- Fix drag not ending when mouse is released outside event control scope
- Fix drag starting whenever an annotation is clicked
@reckart
#283 - Resize span
234f0e8 
- Add more classes to SVG elements in brat editor so we know what is what
- Fix exception in selectionToOffsets if nothing was selected (i.e. no ranges)
@reckart reckart merged commit 1c962aa into main Jan 4, 2023
@reckart reckart deleted the feature/283-Resize-span branch January 4, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Annotation Module: brat
Projects
Kanban
Archived in project
Milestone
27.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart